fix Dict bug #86
Merged
fix Dict bug #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Collaborator
|
The manifest looks weird. I am going to revert the offending pr and merge the other one |
Collaborator
|
Can you remove the |
Collaborator
Author
|
the other one doesn't have tests strict enough, it wouldn't catch future similar bugs |
Collaborator
|
Yes we can merge this, instead, but lets not include the bson dump |
CarloLucibello
force-pushed
the
master
branch
from
cbdcf98 to
80138a0
Compare
Collaborator
|
seems like you've removed the bson entirely now? |
Collaborator
Author
|
that bson is not part of the tests, is something that probably was inadvertedly uploaded. It is very easy to produce and push it by mistake, e.g. running the examples in the readme, so I added it to .gitignore |
Collaborator
|
Sure. Lets have this in and see where we get |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #85 introduced in #29 where a
Dict{Symbol,T}is reloaded as aBSONDict.This PR basically reverts #29 and implements #73.
Notice that we still have the bug that
Dict{Symbol,T}ir reloadedDict{Symbol,Any}. That is a long-standing problem that should be fixed elsewhere (I'll file an issue).